Skip to content

[BEAM-4005] Futurize tools subpackage#5343

Closed
Fematich wants to merge 2 commits into
apache:masterfrom
Fematich:tools
Closed

[BEAM-4005] Futurize tools subpackage#5343
Fematich wants to merge 2 commits into
apache:masterfrom
Fematich:tools

Conversation

@Fematich

Copy link
Copy Markdown
Contributor

This pull request prepares the tools subpackage for Python 3 support. This PR is part of a series in which all subpackages will be updated using the same approach.
This approach has been documented here and the first pull request in the series (Futurize coders subpackage) demonstrating this approach can be found at #5053.

R: @aaltay @tvalentyn

import time
from builtins import range

from past.utils import old_div

@RobbeSneyders RobbeSneyders May 12, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you replace old_div with the new Python 3 division?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in new commit

@Fematich

Copy link
Copy Markdown
Contributor Author

run python precommit

@tvalentyn tvalentyn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@asfgit asfgit closed this in c1650da Jun 13, 2018
@aaltay

aaltay commented Jun 13, 2018

Copy link
Copy Markdown
Member

LGTM. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants